Context Navigation

fixed: (In [bc9c521]) Apply the 'Subs Edit Box' hotkey handling to all of the text boxes in the subs edit area rather than just the main text edit. Closes #1431.

19:23 Changeset [bc9c521]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/subs_edit_box.cpp

Apply the 'Subs Edit Box' hotkey handling to all of the text boxes in the subs edit area rather than just the main text edit. Closes #1431.

Originally committed to SVN as r6380.

19:23 Changeset [0dc0135]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/video_display.cpp
aegisub/src/video_display.h

Select the appropriate entry in the zoom dropdown when the zoom is changed externally so that keyboard navigation works. Updates #1433.

Originally committed to SVN as r6379.

19:23 Changeset [2d5df24f]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/video_box.cpp
aegisub/src/video_display.cpp

Update the zoom on Enter in the zoom box. Updates #1433.

Originally committed to SVN as r6378.

19:23 Changeset [772c8de]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/command/edit.cpp

Fix accelerator conflict between Redo and Find and Replace

Originally committed to SVN as r6377.

19:22 Ticket #1434 (More accelerators for trunk) closed by plorkyeran

fixed: (In [16db1eb]) Add more menu accelerators and fix a conflict between View and Video. Patch by catntabile. Closes #1434.

19:22 Changeset [16db1eb]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/command/edit.cpp
aegisub/src/command/video.cpp
aegisub/src/libresrc/default_menu.json
aegisub/src/menu.cpp

Add more menu accelerators and fix a conflict between View and Video. Patch by catntabile. Closes #1434.

Originally committed to SVN as r6376.

19:22 Ticket #1430 (Clip visual tool causes crash) closed by plorkyeran

fixed: (In [d01c0cf]) Fix crash when drawing a vector clip that does not start with a move. Closes #1430.

19:22 Changeset [d01c0cf]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/spline.cpp

Fix crash when drawing a vector clip that does not start with a move. Closes #1430.

Originally committed to SVN as r6375.

16:30 Ticket #1434 (More accelerators for trunk) created by cantabile

I'm mostly interested in accelerators for the "Recent" menu items and …

14:26 Ticket #1433 (Video zoom combobox is kinda broken) created by cantabile

1) It's impossible to change the zoom level with the scroll wheel while …

13:40 Ticket #1432 (Audio display repainting issues) created by cantabile

1) When changing the end time of the current line, the end marker is not …

11:12 Ticket #1431 (Pressing enter in the start time, end time and duration boxes should go to ...) created by cantabile

This would be nice to have when making changes to the start or end times …

02:19 Ticket #1430 (Clip visual tool causes crash) created by torque

If an incorrectly formatted \i?clip is inserted into the line, the vector …

01:55 Ticket #1429 (libass causes crash.) created by torque

With certain specific conditions, libass throws an exception/error that is …

01/26/2012:

23:23 Changeset [4746ae8]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/dialog_paste_over.cpp

Really unhardcode the Paste Over dialog's height rather than just the width

Originally committed to SVN as r6374.

23:21 Changeset [a54983a]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/dialog_paste_over.cpp
aegisub/src/dialog_paste_over.h
aegisub/src/subs_grid.cpp

Fix a few minor issues with the Paste Over dialog

Remove the pointlessly hardcoded height of the checklist.

Set the parent correctly.

Set the initial focus to the OK button.

Originally committed to SVN as r6373.

22:46 Ticket #1407 (Shift + mousewheel scroll in Subs Grid to scroll by page at once) closed by plorkyeran

fixed: (In [8c246e1]) Make shift-scrollwheel scroll the grid a page at a time. Closes #1407.

22:46 Changeset [8c246e1]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/base_grid.cpp

Make shift-scrollwheel scroll the grid a page at a time. Closes #1407.

Originally committed to SVN as r6372.

22:27 Changeset [6d550b4a]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/base_grid.cpp

Repaint the entire grid on timing changes

Timing changes can potentially make all of the columns need to be
repainted (due to the collision line color), and the grid currently
isn't smart enough to know when this is actually the case, so just
always repaint the entire thing.

Originally committed to SVN as r6371.

22:13 Changeset [a1ad0fa]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/subs_edit_box.cpp

Use Scintilla's logic for deciding when to coalesce edit box changes

Scintilla's modification notifications don't expose enough information
to do a very good job of deciding when to group changes with previous
ones, but it does expose when Scintilla thinks undo groups should end,
so just use that.

This should significantly improve the behavior of undo when editing
lines in the edit box.

Originally committed to SVN as r6370.

21:19 Changeset [d55f162]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/auto4_lua_assfile.cpp

Fix backwards-compatibilty break in the lua karaoke parser

Insert an empty syllable at the beginning of the karaoke syllable table
to better mimick 2.1.x's behavior.

Originally committed to SVN as r6369.

20:51 Ticket #1428 (Make an option for the spellchecker ignore comments) closed by plorkyeran

fixed: (In [0aec0a9]) Add an option to skip over commented lines in the spell checker. Closes #1428.

20:51 Changeset [0aec0a9]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/dialog_spellchecker.cpp
aegisub/src/dialog_spellchecker.h
aegisub/src/libresrc/default_config.json

Add an option to skip over commented lines in the spell checker. Closes #1428.

Originally committed to SVN as r6368.

20:17 Changeset [92ae4a6]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/ass_style.cpp

Fix truncation of all float fields in styles

Originally committed to SVN as r6367.

20:08 Changeset [99a7eec]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/subs_grid.cpp

Significantly speed up duplicating multiple lines

SubtitlesGrid::DuplicateLines iterated over the entire file multiple
times for each line duplicated, making duplicating large numbers of
lines extremely slow.

Originally committed to SVN as r6366.

20:08 Changeset [15a4eca]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/ass_file.cpp
aegisub/src/subtitle_format.cpp
aegisub/src/subtitle_format.h
aegisub/src/subtitle_format_ass.cpp
aegisub/src/subtitle_format_ass.h
aegisub/src/subtitle_format_encore.cpp
aegisub/src/subtitle_format_encore.h
aegisub/src/subtitle_format_microdvd.cpp
aegisub/src/subtitle_format_microdvd.h
aegisub/src/subtitle_format_mkv.cpp
…

Fix crash on (auto)save when using CSRI and video is open

Calling AssFile::Save/Load from multiple threads (even on different
objects) was not safe due to that is uses SubtitleFormat internally,
which was inheriently thread-unsafe. To fix this, change
SubtitleFormat's interface to support immutable implementations, and
make all of the current implementations immutable.

This isn't a perfect solution - making a subtitle format implemented in
lua immutable would be rather difficult - so at some point in the future
SubtitleFormat should probably be changed to a factory which returns new
objects from GetReader/GetWriter.

Originally committed to SVN as r6365.

17:32 Ticket #1428 (Make an option for the spellchecker ignore comments) created by piovisqui

The spell checker should have an option (option, not default) to ignore …

00:29 Ticket #1415 (\clip(<number>,<drawings>) is not recognized in visual tools) closed by plorkyeran

fixed: (In [d001d66]) Add support for the scale parameter of vector clips. Closes #1415.

00:29 Changeset [d001d66]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/spline.cpp
aegisub/src/spline.h
aegisub/src/visual_tool.cpp
aegisub/src/visual_tool_vector_clip.cpp

Add support for the scale parameter of vector clips. Closes #1415.

Originally committed to SVN as r6364.

01/25/2012:

23:09 Ticket #1427 (Shift Times dialog - load settings from history on doubleclick) closed by plorkyeran

fixed: (In [214079a]) Load Shift Times settings from history on double-click Redesign how shift times history is saved. Previously it stored the localized strings in the history file, which are not particularly parsable as the format may differ between locales. Rather than doing this, store the raw settings in a json file, and generate the history strings on display. In addition to making it much easier to load old settings, this makes it so that the history is always displayed using the current locale, rather than the locale in which the shifting was done. Closes #1427.

23:09 Changeset [214079af]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/dialog_shift_times.cpp
aegisub/src/dialog_shift_times.h

Load Shift Times settings from history on double-click

Redesign how shift times history is saved. Previously it stored the
localized strings in the history file, which are not particularly
parsable as the format may differ between locales. Rather than doing
this, store the raw settings in a json file, and generate the history
strings on display. In addition to making it much easier to load old
settings, this makes it so that the history is always displayed using
the current locale, rather than the locale in which the shifting was
done.

Closes #1427.

Originally committed to SVN as r6363.

19:07 Ticket #1417 (Restore last position in grid on file open) closed by plorkyeran

fixed: (In [2094814]) Save the current row and scroll position in the file and restore it when the file is reopened. Closes #1417.

19:07 Changeset [2094814]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/ass_file.h
aegisub/src/base_grid.cpp
aegisub/src/base_grid.h

Save the current row and scroll position in the file and restore it when the file is reopened. Closes #1417.

Originally committed to SVN as r6362.

19:07 Ticket #1418 ("Recombine lines" trims "t" and more options) closed by plorkyeran

fixed: (In [71a4e38]) Fix over-escaping that resulted in Recombine Lines stripping 't' rather than tabs. Closes #1418.

19:07 Changeset [71a4e38]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/subs_grid.cpp

Fix over-escaping that resulted in Recombine Lines stripping 't' rather than tabs. Closes #1418.

Originally committed to SVN as r6361.

19:07 Ticket #1420 (Leaving the hotkey column emtpy in hotkey preferences crashes) closed by plorkyeran

fixed: (In [a4eb7ef]) Fix crash with empty hotkeys. Closes #1420.

19:07 Changeset [a4eb7ef5]stable by Thomas Goyne <plorkyeran@…>

aegisub/libaegisub/common/hotkey.cpp

Fix crash with empty hotkeys. Closes #1420.

Originally committed to SVN as r6360.

19:07 Changeset [e9dcbf6]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/main.cpp
aegisub/src/main.h

Fix compilation errors when wxUSE_ON_FATAL_EXCEPTION is not enabled. Updates #1423.

Originally committed to SVN as r6359.

19:06 Ticket #1425 (Allow audio display to be shown regardless audio being loaded) closed by plorkyeran

fixed: (In [d798d69]) Enable the dummy audio provider in release builds. Closes #1425.

19:06 Changeset [d798d69]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/command/audio.cpp

Enable the dummy audio provider in release builds. Closes #1425.

Originally committed to SVN as r6358.

17:29 Ticket #1427 (Shift Times dialog - load settings from history on doubleclick) created by tophf

Applies to: Shift Times dialog Enhancement: load settings from history on …

17:12 Ticket #1426 (Enhancements for \clip(<x1>,<y2>,<x2>,<y2>) visual tool) created by FichteFoll

It doesn't make any sense to let \clip(<x1>,<y2>,<x2>,<y2>) have lower or …

17:06 Ticket #1425 (Allow audio display to be shown regardless audio being loaded) created by FichteFoll

The audio display gives some kind of orientation and visual feedback for …

16:51 Ticket #1424 (Allow line breaks only in the sub edit box) created by FichteFoll

I thought about introducing some kind of "special character" that forces a …

16:47 Ticket #1423 (wxHandleFatalExceptions is not always available) created by liori

wxHandleFatalExceptions is available only if WX was compiled with …

16:38 Ticket #1422 (Highlight several blocks in the subtitle grid) created by FichteFoll

It would be really nice to have override blocks being highlighted and …

16:31 Ticket #1421 (Reopen the lastly opened script (and prompt for video/audio) when ...) created by FichteFoll

When restarting for whatever reason (changing the language for example) …

16:23 Ticket #1420 (Leaving the hotkey column emtpy in hotkey preferences crashes) created by FichteFoll

When I leave the hotkey field in the preferences empty Aegisub crashes …

16:08 Ticket #1419 (Interface issue when opening Aegisub from shell without associated data) created by FichteFoll

Opening Aegisub from shell (dblclick) without any associated data results …

15:56 Ticket #1418 ("Recombine lines" trims "t" and more options) created by FichteFoll

The "Recombine lines" function trims lower-case "t"s at the start or end …

15:53 Ticket #1417 (Restore last position in grid on file open) created by tophf

Restore last position in grid on ASS-file open and select the line. Could …

15:47 Ticket #1416 (Override buttons below Actor combo box flicker while resizing) created by FichteFoll

The color picker and other override buttons below the Actor combo control …

15:43 Ticket #1415 (\clip(<number>,<drawings>) is not recognized in visual tools) created by FichteFoll

When having \clip(<number>,<drawings>) in a line, the visual tool for …

05:49 Changeset [e7307d24]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/placeholder_ctrl.h

Fix odd behavior when switching active lines with the Effect or Actor boxes focused

Originally committed to SVN as r6357.

05:48 Changeset [f8c27fe]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/audio_display.cpp
aegisub/src/dialog_detached_video.cpp
aegisub/src/video_display.cpp
aegisub/src/video_slider.cpp

Skip unprocessed key events. Updates #1408.

Originally committed to SVN as r6356.

04:59 Ticket #1311 (Selecting lines in the subtitles grid doesn't work as expected) closed by plorkyeran

fixed: (In [26c3e13]) Fix poor synchronization between mouse and keyboard modifications to the selection Combining Shift+Up/Down (or Home/End or Page Up/Page Down) with shift-clicking had very odd results due to that they used separate variables to decide where to extend from (and even when only one was used they were handled incorrectly in some cases). Closes #1311.

04:59 Changeset [26c3e13]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/base_grid.cpp
aegisub/src/base_grid.h

Fix poor synchronization between mouse and keyboard modifications to the selection

Combining Shift+Up/Down (or Home/End or Page Up/Page Down) with
shift-clicking had very odd results due to that they used separate
variables to decide where to extend from (and even when only one was
used they were handled incorrectly in some cases).

Closes #1311.

Originally committed to SVN as r6355.

04:59 Changeset [e6d86a1]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/audio_controller.cpp

Don't remove audio files from the recently used files list when loading is cancelled

Originally committed to SVN as r6354.

02:16 Ticket #1414 (Translation Assistant: Keypad's Enter is doing an actual line break) created by le_ikari

I just noticed that in the Translation Assistant, if I press the Enter …

00:40 Changeset [bce29f5a]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/video_context.cpp

Fix bug where "Play current line" would not stop at the end of the line if video was already playing

Originally committed to SVN as r6353.

00:21 Ticket #1413 (aegisub.video_size() returns different values for the help string function ...) closed by plorkyeran

fixed: (In [a24f169]) Let macros update their help string from the validate function If the second return value from the validate function exists and is a non-empty string, replace the macro's help text with that string. Revert r6327, as this is a better solution to the same problem. Closes #1413.

00:21 Changeset [a24f169]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/auto4_lua.cpp
aegisub/src/auto4_lua.h
aegisub/src/menu.cpp

Let macros update their help string from the validate function

If the second return value from the validate function exists and is a
non-empty string, replace the macro's help text with that string.

Revert r6327, as this is a better solution to the same problem.

Closes #1413.

Originally committed to SVN as r6352.

00:21 Changeset [3140d90]stable by Thomas Goyne <plorkyeran@…>

aegisub/universalchardet/nsUniversalDetector.cpp

Report the endianness of detected UTF-16 and UTF-32

'UTF-16' is big-endian UTF-16, so returning it for UTF-16LE is incorrect
and results in line_iterator failing on UTF-16LE.

Originally committed to SVN as r6351.

01/24/2012:

20:37 Ticket #1413 (aegisub.video_size() returns different values for the help string function ...) created by torque

See the attached script. When run, the validation macro returns true, but …

20:11 Ticket #1412 (Segfault due canceling of loading audio) created by petrkr

Hi, when you select Load audio and you press "Cancel" then whole aegi …

20:07 Ticket #1411 (Hotkey to temporarily show original video without subs) created by tophf

Hotkey to temporarily show original video without subs would be very …

09:29 Ticket #1410 (SRT Parser does not handle blank lines at end of file) created by petrkr

Hi, I found problem in SRT parser at one file. Probably it's due file is …

01:46 Changeset [1034d16]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/export_fixstyle.cpp

Auto-apply AssFixStylesFilter when sending subtitles to the renderer

Originally committed to SVN as r6350.

01:28 Changeset [1c14740]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/dialog_timing_processor.cpp

Fix check for 'start after' and 'end after' keyframe snapping in the TPP

Originally committed to SVN as r6349.

01/23/2012:

23:53 Changeset [df9f46b]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/dialog_timing_processor.cpp

Actually read the values from the TPP dialog before applying processing

Originally committed to SVN as r6348.

23:07 Changeset [3b5bc88]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/include/aegisub/video_provider.h
aegisub/src/video_context.cpp
aegisub/src/video_provider_cache.h
aegisub/src/video_provider_ffmpegsource.cpp
aegisub/src/video_provider_ffmpegsource.h

Write the video's colorspace to the script info section

Originally committed to SVN as r6347.

21:29 Ticket #1409 (Infinite loop in the video display (I guess)) created by cantabile

To reproduce: 1. open aegisub 2. open a video file 3. open an audio file …

21:14 Ticket #1375 (Audio doesn't play in full when using portaudio) closed by plorkyeran

fixed: (In [f2aadc7]) Add automatic host API selection to the portaudio player Portaudio defaults to using the most stable widely available host API, rather than the highest performance or quality, and as a result the default host API on windows (MME) is really quite bad. As such, add logic to select the best host API for the selected output device. Closes #1375.

21:14 Changeset [f2aadc74]stable by Thomas Goyne <plorkyeran@…>

aegisub/src/audio_player_portaudio.cpp
aegisub/src/audio_player_portaudio.h

Add automatic host API selection to the portaudio player

Portaudio defaults to using the most stable widely available host API,
rather than the highest performance or quality, and as a result the
default host API on windows (MME) is really quite bad. As such, add
logic to select the best host API for the selected output device.

Closes #1375.

Originally committed to SVN as r6346.

21:01 Changeset [e6252ae]stable by Thomas Goyne <plorkyeran@…>