Timeline
03/06/10:
- 20:04 Ticket #1171 (Translation Assistant bug in Mac OS X) created by
-
It's impossible to write in the translation box at the bottom of the Translation Assistant window.
- 04:55 Changeset [4171] by
-
- trunk/aegisub/src/libresrc/default_mru.json
- trunk/aegisub/src/libresrc/libresrc.cpp
- trunk/aegisub/src/libresrc/libresrc.h
- Return an std::string
- Be const correct.
- Use c_str() to ensure null termination.
- Remove stray , from default_mru.json.
- 03:54 Ticket #1170 (Configuration status fixes at the end of configure output.) created by
-
I noticed two things that I can't fix right now:
- Audio Player is blank when OSS is the only player.
- Video,Audio Provider is blank when there is no FFMPEG detected.
03/03/10:
- 02:28 Changeset [4170] by
-
- trunk/aegisub/build/aegisub_vs2008/aegisub_vs2008.vcproj
- trunk/aegisub/tools/common_respack_packresources.vsprops
Update the windows build system to work with the changes made in r4169.
- 01:44 Changeset [4169] by
-
- trunk/aegisub/src/libresrc
- trunk/aegisub/src/libresrc/Makefile.am
- trunk/aegisub/src/libresrc/default_mru.json
- trunk/aegisub/src/libresrc/libresrc.cpp
- trunk/aegisub/src/libresrc/libresrc.h
- trunk/aegisub/tools/common-respack.cpp
Change how libresrc is built:
- Instead of putting code into the .(c|h) files place it into two new files libresrc.(c|h)
- Bitmaps now go into bitmaps.(c|h)
- Default configs into default_config.(c|h)
With this approach we can easily embed any resources by simply calling it with common-respack and not having to do anything else.
03/02/10:
- 06:41 Changeset [4168] by
-
- branches/audio_display_rewrite/aegisub/src/audio_box.cpp
- branches/audio_display_rewrite/aegisub/src/audio_controller.cpp
- branches/audio_display_rewrite/aegisub/src/audio_controller.h
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
- branches/audio_display_rewrite/aegisub/src/audio_timing.h
- branches/audio_display_rewrite/aegisub/src/audio_timing_dialogue.cpp
- branches/audio_display_rewrite/aegisub/src/frame_main_events.cpp
Replace audio selection concept with primary playback range concept. The primary range is still considered to be the part to be displayed as "selected" in the audio display, this needs to be changed so the timing controller can report ranges of differently styled audio, e.g. normal, selected, passive.
- 04:40 Changeset [4167] by
-
- branches/audio_display_rewrite/aegisub/src/selection_controller.h
Fix mistakes in Doxygen comments
- 02:40 Changeset [4166] by
-
- branches/audio_display_rewrite/aegisub/src/base_grid.cpp
Fix grid not updating and reporting all changes when updated through the SubtitleSelectionController interface.
- 02:20 Changeset [4165] by
-
- branches/audio_display_rewrite/aegisub/src/audio_box.cpp
- branches/audio_display_rewrite/aegisub/src/audio_display.h
- branches/audio_display_rewrite/aegisub/src/audio_karaoke.cpp
Remove the remaining "legacy publics" from AudioDisplay, re-implement a few of the old audio toolbar buttons, document the purpose of the now commented out lines in other files using the now-removed legacy publics. Change Doxygen text for AudioDisplay now that it's "clean".
03/01/10:
- 20:36 Ticket #1169 (Merge r4164 from trunk into 2.1.9) created by
-
Merge r4164 from trunk to 2.1.9
Fix typo. (from kovensky), should be merged to 2.1.9
- 20:36 Changeset [4164] by
-
- trunk/aegisub/configure.in
Fix typo. (from kovensky), should be merged to 2.1.9
- 10:27 Changeset [4163] by
-
- branches/audio_display_rewrite/aegisub/src/frame_main.cpp
Fix layout issues with editing area not filling vertical space left by the video display.
- 09:18 Changeset [4162] by
-
- branches/audio_display_rewrite/aegisub/Makefile.am
Remove reporter from build, as it fails building on Mac, and is not used for anything either way.
- 01:42 Changeset [4161] by
-
- branches/audio_display_rewrite/aegisub/src/frame_main.cpp
Only use SetWindowModified() on Mac if building 32 bit, and of course never on non-Mac.
- 01:40 Changeset [4160] by
-
- branches/audio_display_rewrite/aegisub/src/audio_box.cpp
- branches/audio_display_rewrite/aegisub/src/audio_box.h
- branches/audio_display_rewrite/aegisub/src/audio_controller.cpp
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
- branches/audio_display_rewrite/aegisub/src/frame_main.cpp
Move creation of dialogue controller to audio box, pass the subtitle selection controller (the grid) to the audio box. Changing line in the subs grid now changes the audio selection!
02/26/10:
- 03:49 Changeset [4159] by
-
- branches/audio_display_rewrite/aegisub/src/base_grid.cpp
- branches/audio_display_rewrite/aegisub/src/base_grid.h
- branches/audio_display_rewrite/aegisub/src/dialog_fonts_collector.cpp
- branches/audio_display_rewrite/aegisub/src/dialog_kara_timing_copy.cpp
- branches/audio_display_rewrite/aegisub/src/dialog_options.cpp
- branches/audio_display_rewrite/aegisub/src/dialog_resample.cpp
- branches/audio_display_rewrite/aegisub/src/dialog_search_replace.cpp
- branches/audio_display_rewrite/aegisub/src/dialog_selection.cpp
- branches/audio_display_rewrite/aegisub/src/dialog_shift_times.cpp
- branches/audio_display_rewrite/aegisub/src/dialog_spellchecker.cpp
- …
Make the BaseGrid a SubtitleSelectionController and litter hopefully correct selection-change announcements around the code. Not yet tested.
- 01:18 Changeset [4158] by
-
- trunk/contrib/csri/lib/list.c
Fix a memory leak in csri caused by csri_wrap_insts never being freed.
02/25/10:
- 22:45 Changeset [4157] by
-
- trunk/aegisub/src/audio_provider_hd.cpp
- trunk/aegisub/src/audio_provider_ram.cpp
- trunk/aegisub/src/auto4_lua.cpp
- trunk/aegisub/src/dialog_progress.cpp
- trunk/aegisub/src/dialog_style_manager.cpp
- trunk/aegisub/src/mkv_wrap.cpp
- trunk/aegisub/src/mkv_wrap.h
Fix a smattering of memory leaks.
- 22:14 Changeset [4156] by
-
- branches/audio_display_rewrite/aegisub/src/audio_controller.cpp
- branches/audio_display_rewrite/aegisub/src/audio_timing.h
- branches/audio_display_rewrite/aegisub/src/audio_timing_dialogue.cpp
- branches/audio_display_rewrite/aegisub/src/selection_controller.h
Add untested handling of subtitle selection to dialogue timing controller.
- 19:46 Changeset [4155] by
-
- branches/audio_display_rewrite/aegisub/build/aegisub_vs2008/aegisub_vs2008.vcproj
- branches/audio_display_rewrite/aegisub/src/selection_controller.h
Add SubtitleSelectionController and SubtitleSelectionListener interfaces.
- 18:32 Changeset [4154] by
-
- branches/audio_display_rewrite/aegisub/build/aegisub_vs2008/aegisub_vs2008.vcproj
Introduce a new Controllers category in the MSVC project.
- 10:32 Changeset [4153] by
-
- branches/audio_display_rewrite/aegisub/src/audio_colorscheme.cpp
- branches/audio_display_rewrite/aegisub/src/audio_renderer_spectrum.cpp
Tweak audio colour scheme and spectrum power scaling a bit further
- 09:24 Ticket #1018 (HSL_to_RGB() in auto4 utils rounds incorrectly) reopened by
- Reopening this, I just noticed that the change actually breaks HSL_to_RGB by no longer multiplying the results by 255, so it suddenly returns RGB in range 0..1 instead of 0..255.
- 09:03 Ticket #1154 (Skip CSRI helper library in linking to VSFilter) closed by
- fixed: This is somewhat documented on [Build/Windows] now. The next Windows installer will be updated to ship for this configuration.
- 04:52 Changeset [4152] by
-
- branches/audio_display_rewrite/aegisub/src/block_cache.h
Fix logic error in DataBlockCache<> causing cache sizes to explode: Data blocks were never getting disposed of because of a misplaced "not".
- 03:16 Changeset [4151] by
-
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
Fix audio timeline showing the wrong time for all other samplerates than 44100 Hz.
- 02:53 Changeset [4150] by
-
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
- branches/audio_display_rewrite/aegisub/src/audio_display.h
Have the mouse tracking cursor be followed by a timestamp.
- 01:49 Changeset [4149] by
-
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
Prevent track cursor from flickering when moving the mouse across the audio display during playback.
02/24/10:
- 19:36 Ticket #1167 (prompted to save non-existent changes when opening a file immediately ...) closed by
- fixed: This has been fixed in wx trunk, if you update your wx (or Aegisub releases using a newer wx build) then it will fix the problem.
- 19:06 Ticket #1168 (crash when changing the actor) created by
-
Steps to reproduce:
1. Open a subtitle file
2. Select a line in the script
3. Click in the Actor field above, type in a name, hit the return key
Results:
crash.
Seems repeatable on demand.
- 18:50 Ticket #1167 (prompted to save non-existent changes when opening a file immediately ...) created by
-
Steps to reproduce:
1. Double-click the Aegisub application icon in Finder
2. Choose File > Open Subtitles... from the menu
3. Choose the subtitle file you want to open and click Open
Actual results:
- prompt appears reading "Unsaved changes" "Save before continuing?"
Expected results:
- Since I haven't done anything except launch the app, there should be nothing to save, and I should not get this prompt.
Alternate steps to reproduce:
1. Drag an .ass file onto the Aegisub application icon in Finder
- The first thing Aegisub does after launching in this case is prompt you to save the unsaved changes.
- 02:12 Changeset [4148] by
-
- branches/audio_display_rewrite/aegisub/src/audio_box.cpp
- branches/audio_display_rewrite/aegisub/src/audio_controller.cpp
- branches/audio_display_rewrite/aegisub/src/audio_controller.h
- branches/audio_display_rewrite/aegisub/src/frame_main_events.cpp
Make playback of the audio selection a separate playback mode, and add changing the playback end when the selection is changed.
- 02:00 Changeset [4147] by
-
- branches/audio_display_rewrite/aegisub/src/audio_controller.cpp
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
Missing includes for building without precompiled headers.
- 01:55 Changeset [4146] by
-
- branches/audio_display_rewrite/aegisub/src/audio_provider.cpp
- branches/audio_display_rewrite/aegisub/src/audio_renderer_waveform.cpp
- branches/audio_display_rewrite/aegisub/src/audio_renderer_waveform.h
- branches/audio_display_rewrite/aegisub/src/include/aegisub/audio_provider.h
Remove waveform peaks calculation from audio provider, and write new peaks calculation + rendering that shows both average and extreme peaks.
- 01:45 Ticket #1166 (Segmentation fault at startup of aegisub_2.1.8/2.1.9) created by
-
I'm getting 'Segmentation fault (core dumped)' while trying to run aegisub 2.1.8. Also I tried prebuilt version from aegisub.org and aegisub_2.1.9 (co from SVN).
I tried to debug it but with no luck - it crashes at:
aegisub/src/video_display.cpp:161: SetCursor(cursor);
Stacktrace:
wxFileName::SplitVolume() at 0x34ffe893f7 wxFileName::SplitPath() at 0x34ffe8971f wxFileName::Assign() at 0x34ffe8ae28 wxFileName() at /usr/include/wx-2.8/wx/filename.h:109 AegisubApp::OnFatalException() at /home/max/workspace/aegisub_2.1.9/aegisub/src/main.cpp:285 wxFatalSignalHandler() at 0x34ffef65cc <signal handler called>() at 0x3a6620f0f0 wxWindow::GTKGetWindow() at 0x3f001f4378 wxWindow::GTKUpdateCursor() at 0x3f001f53a5 wxWindow::SetCursor() at 0x3f001f547b VideoDisplay::ShowCursor() at /home/max/workspace/aegisub_2.1.9/aegisub/src/video_display.cpp:162 VisualToolCross::VisualToolCross() at /home/max/workspace/aegisub_2.1.9/aegisub/src/visual_tool_cross.cpp:53 VideoDisplay::SetVisualMode() at /home/max/workspace/aegisub_2.1.9/aegisub/src/video_display.cpp:623 VideoDisplay::VideoDisplay() at /home/max/workspace/aegisub_2.1.9/aegisub/src/video_display.cpp:133 VideoBox::VideoBox() at /home/max/workspace/aegisub_2.1.9/aegisub/src/video_box.cpp:101 FrameMain::InitContents() at /home/max/workspace/aegisub_2.1.9/aegisub/src/frame_main.cpp:566 FrameMain::FrameMain() at /home/max/workspace/aegisub_2.1.9/aegisub/src/frame_main.cpp:158 AegisubApp::OnInit() at /home/max/workspace/aegisub_2.1.9/aegisub/src/main.cpp:222 wxEntry() at 0x34ffe97a92 main() at /home/max/workspace/aegisub_2.1.9/aegisub/src/main.cpp:76
After I change
SetCursor(cursor); to SetCursor(wxNullCursor);
Aegisub continues to load but segfaults in second time at
aegisub/src/frame_main.cpp:849: Show(true);
Stacktrace:
wxWindow::DoSetSize() at 0x3f001f9e3e wxBoxSizer::RecalcSizes() at 0x3f002dbf9c wxBoxSizer::RecalcSizes() at 0x3f002dc026 wxBoxSizer::RecalcSizes() at 0x3f002dc026 wxWindowBase::Layout() at 0x3f002ee9e0 wxPanel::OnSize() at 0x3f00314a86 wxEvtHandler::ProcessEventIfMatches() at 0x34ffef2070 wxEventHashTable::HandleEvent() at 0x34ffef3034 wxEvtHandler::ProcessEvent() at 0x34ffef3117 0x3f001f8518 g_closure_invoke() at 0x36cf20ba8e 0x36cf220ec3 g_signal_emit_valist() at 0x36cf222259 g_signal_emit() at 0x36cf2227a3 gtk_widget_size_allocate() at 0x7ffff747b56e 0x7ffff73ba6b3 g_closure_invoke() at 0x36cf20b9d9 0x36cf2207dc g_signal_emit_valist() at 0x36cf222259 g_signal_emit() at 0x36cf2227a3 gtk_widget_size_allocate() at 0x7ffff747b56e 0x3f001f2714 0x3f001f3430 g_closure_invoke() at 0x36cf20b9d9 0x36cf2207dc g_signal_emit_valist() at 0x36cf222259 g_signal_emit() at 0x36cf2227a3 gtk_widget_size_allocate() at 0x7ffff747b56e 0x7ffff73ba6b3 g_closure_invoke() at 0x36cf20b9d9 0x36cf2207dc g_signal_emit_valist() at 0x36cf222259 g_signal_emit() at 0x36cf2227a3 gtk_widget_size_allocate() at 0x7ffff747b56e 0x3f001f2714 0x3f001f3430 g_closure_invoke() at 0x36cf20b9d9 0x36cf2207dc g_signal_emit_valist() at 0x36cf222259 g_signal_emit() at 0x36cf2227a3 gtk_widget_size_allocate() at 0x7ffff747b56e 0x3f001f2714 0x3f001f3430 g_closure_invoke() at 0x36cf20b9d9 0x36cf2207dc g_signal_emit_valist() at 0x36cf222259 g_signal_emit() at 0x36cf2227a3 gtk_widget_size_allocate() at 0x7ffff747b56e 0x7ffff748ed5d g_closure_invoke() at 0x36cf20ba8e 0x36cf2207dc g_signal_emit_valist() at 0x36cf222259 g_signal_emit() at 0x36cf2227a3 gtk_widget_size_allocate() at 0x7ffff747b56e 0x7ffff749058b g_closure_invoke() at 0x36cf20ba8e 0x36cf2207dc g_signal_emit_valist() at 0x36cf222259 g_signal_emit() at 0x36cf2227a3 gtk_widget_show() at 0x7ffff747ea8b wxWindow::Show() at 0x3f001f966c wxTopLevelWindowGTK::Show() at 0x3f001eff88 FrameMain::SetDisplayMode() at /home/max/workspace/aegisub_2.1.9/aegisub/src/frame_main.cpp:849 FrameMain::InitContents() at /home/max/workspace/aegisub_2.1.9/aegisub/src/frame_main.cpp:609 FrameMain::FrameMain() at /home/max/workspace/aegisub_2.1.9/aegisub/src/frame_main.cpp:158 AegisubApp::OnInit() at /home/max/workspace/aegisub_2.1.9/aegisub/src/main.cpp:222 wxEntry() at 0x34ffe97a92 main() at /home/max/workspace/aegisub_2.1.9/aegisub/src/main.cpp:76
Also in this case ~/.aegisub/crashlog.txt is created with two bytes length (these bytes are: 0x0a 0x0a)
Im using Fedora 12 (x86_64) and wxWidgets 2.8.10
- 00:23 Changeset [4145] by
-
- branches/audio_display_rewrite/aegisub/src/audio_controller.h
Fix build for systems not using precompiled headers
- 00:07 Changeset [4144] by
-
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
Various fixes for audio display on Mac
- 00:00 Changeset [4143] by
-
- branches/audio_display_rewrite/aegisub/src/agi_pre.h
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
Paint audio display with an auto-buffered paint DC, which while not advertised too well, avoids all risks of flicker, and simplifies drawing somewhat.
02/23/10:
- 23:58 Changeset [4142] by
-
- branches/audio_display_rewrite/aegisub/src/audio_renderer.cpp
Logic fixes to audio image blitting
- 12:05 Changeset [4141] by
-
- branches/audio_display_rewrite/aegisub/src/audio_renderer_waveform.cpp
Fix rendering of blank audio in waveform mode
02/22/10:
- 22:18 Build/Unix edited by
- Add note about the version this applies to. (diff)
- 22:16 Build edited by
- Add note about source (type) availability. (diff)
- 22:16 Developer/DevelDep edited by
- Add a note about the version this applies to. (diff)
- 19:15 Changeset [4140] by
-
- branches/audio_display_rewrite/aegisub/src/audio_controller.cpp
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
Fix a bunch of compile errors and warnings on GCC
- 13:07 Ticket #1165 (Configure on OS X requires FontConfig even with libass disabled) created by
-
On OS X, Aegisub does not directly use Font Config, only libass uses Font Config. If you you configure with --disable-libass, configure still checks for Font Config and fails if it is not present.
(Tested on audio display rewrite branch.)
02/21/10:
- 17:34 Ticket #1164 (Potential crash in update checker) created by
-
Missing error checking in the update checker can cause crashes.
In dialog_version_check.cpp, AegisubVersionCheckerThread::DoCheck(), the following line:
std::auto_ptr<wxInputStream> stream(http.GetInputStream(path));
No check is made whether http.GetInputStream() returns 0, which might cause crashes later.
- 07:09 Changeset [4139] by
-
- trunk/aegisub/src/frame_main_events.cpp
Fixed a memory leak that occurred whenever the Edit menu was opened due to the Undo/Redo items being replaced with new wxMenuItem's without deleting the previous items (now it just updates the label/enabled status without creating new wxMenuItem's)
- 05:57 Ticket #1163 (Look for TODO, FIXME and HACK comments) created by
-
I'm sure there's far too many FIXME comments and the like around the code. Let's go treasure-hunting.
- 05:35 Changeset [4138] by
-
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
Add snapping to markers.
- 05:34 Changeset [4137] by
-
- branches/audio_display_rewrite/aegisub/src/audio_timing_dialogue.cpp
- branches/audio_display_rewrite/aegisub/src/utils.h
Plop a templated abs() function into utils.h, moving it from audio_timing_dialogue.cpp. (That was a dumb file to put it in in the first place.)
- 02:32 Changeset [4136] by
-
- branches/audio_display_rewrite/aegisub/docs/doxygen/doxyfile_base
- branches/audio_display_rewrite/aegisub/docs/doxygen/pages_aegisub
- branches/audio_display_rewrite/aegisub/docs/doxygen/pages_aegisub/groups.dox
- branches/audio_display_rewrite/aegisub/docs/doxygen/pages_reporter
- branches/audio_display_rewrite/aegisub/docs/doxygen/pages_reporter/groups.dox
- branches/audio_display_rewrite/aegisub/reporter/r_pre.h
- branches/audio_display_rewrite/aegisub/src/agi_pre.cpp
- branches/audio_display_rewrite/aegisub/src/agi_pre.h
Remove a bunch of unwanted svn:mergeinfo properties.
- 02:28 Changeset [4135] by
-
- branches/audio_display_rewrite/aegisub
- branches/audio_display_rewrite/aegisub/src/base_grid.cpp
Merge r4134 from trunk.
- 02:25 Changeset [4134] by
-
- trunk/aegisub/src/base_grid.cpp
Do an additional range check before grabbing a dialogue line by index in BaseGrid. Not doing it makes MSVC debug runtimes spew assertions and whatnot. This shouldn't break anything... I hope it doesn't.
- 02:16 Changeset [4133] by
-
- branches/audio_display_rewrite/aegisub/src/audio_controller.h
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
- branches/audio_display_rewrite/aegisub/src/audio_display.h
Introduce some public functions in AudioDisplay to convert between pixel coordinates and sample indexes. Fix flicker bug when extending selection by moving the start of it. Fix scrollbar not updating when selection was changed.
- 01:22 Changeset [4132] by
-
- branches/audio_display_rewrite/aegisub/src/audio_box.cpp
- branches/audio_display_rewrite/aegisub/src/audio_controller.h
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
- branches/audio_display_rewrite/aegisub/src/audio_timing.h
- branches/audio_display_rewrite/aegisub/src/audio_timing_dialogue.cpp
Shuffle AudioTimingController into audio_timing.h where it more naturally belongs.
- 00:16 Ticket #1162 (Optimise keyframe marker rendering for 2.1.9) closed by
- fixed: (In [4131]) Merge part of r4130 from audio display rewrite into 2.1.9, hoping to get a small speed boost in rendering of keyframe markers on the audio display. (The boost is probably not that great.) Closes #1162.
- 00:16 Changeset [4131] by
-
- branches/aegisub_2.1.9/aegisub
- branches/aegisub_2.1.9/aegisub/src/video_context.cpp
- branches/aegisub_2.1.9/aegisub/src/video_context.h
Merge part of r4130 from audio display rewrite into 2.1.9, hoping to get a small speed boost in rendering of keyframe markers on the audio display. (The boost is probably not that great.) Closes #1162.
- 00:07 Ticket #1162 (Optimise keyframe marker rendering for 2.1.9) created by
-
During work on the audio display rewrite I found a place with a little room for improvement. When drawing keyframe markers in the audio display, a complete copy of the keyframes array is made, instead of just returning a reference to it. Avoiding this allocation + copy during each drawing of the audio display might speed things up slightly, and is safe either way.
02/20/10:
- 23:48 Changeset [4130] by
-
- branches/audio_display_rewrite/aegisub/src/audio_controller.cpp
- branches/audio_display_rewrite/aegisub/src/audio_controller.h
- branches/audio_display_rewrite/aegisub/src/video_context.cpp
- branches/audio_display_rewrite/aegisub/src/video_context.h
Draw some keyframe markers on the audio display! Still no snapping.
- 04:07 Changeset [4129] by
-
- branches/audio_display_rewrite/aegisub/build/aegisub_vs2008/aegisub_vs2008.vcproj
- branches/audio_display_rewrite/aegisub/src/Makefile.am
- branches/audio_display_rewrite/aegisub/src/audio_box.h
- branches/audio_display_rewrite/aegisub/src/audio_colorscheme.cpp
- branches/audio_display_rewrite/aegisub/src/audio_colorscheme.h
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
- branches/audio_display_rewrite/aegisub/src/audio_display.h
- branches/audio_display_rewrite/aegisub/src/audio_provider.cpp
- branches/audio_display_rewrite/aegisub/src/audio_renderer.h
- branches/audio_display_rewrite/aegisub/src/audio_renderer_spectrum.cpp
- …
Add a waveform audio rendering mode in addition to the spectrum rendering mode:
- Implement waveform rendering class, using the existing peak calculation function in AudioProvider. This peak calculation function should be moved out of AudioProvider at a point, it doesn't belong there.
- Document AudioProvider::GetWaveForm()
- Move AudioSpectrumColorMap out of audio_renderer_spectrum and rename it to AudioColorScheme, since it should be a general way of setting the colour scheme of the audio display, at some point.
- Fix bug in spectrum renderer, it tried to free FFTW objects multiple times if unattached and reattached to the audio renderer manager.
- Add menu items in main frame to toggle Audio Spectrum option. Currently this requires a friend class hack to access the audio display to tell it about the change, this should be unnecessary when the options rewrite is done.
02/18/10:
- 18:57 Changeset [4128] by
-
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
- branches/audio_display_rewrite/aegisub/src/audio_display.h
Remove a lot of old commented out code. I originally left it in for reference, but the other existing branches can just as well be used for reference on the old behaviour and implementation of the audio display. Keeping the old code around only made it more annoying to work on audio_display.cpp, having to scroll past it constantly.
- 18:16 Changeset [4127] by
-
- branches/audio_display_rewrite/aegisub/src/audio_box.cpp
- branches/audio_display_rewrite/aegisub/src/audio_display.h
- branches/audio_display_rewrite/aegisub/src/base_grid.cpp
- branches/audio_display_rewrite/aegisub/src/dialog_options.cpp
- branches/audio_display_rewrite/aegisub/src/dialog_styling_assistant.cpp
- branches/audio_display_rewrite/aegisub/src/dialog_translation.cpp
- branches/audio_display_rewrite/aegisub/src/frame_main.cpp
- branches/audio_display_rewrite/aegisub/src/frame_main_events.cpp
- branches/audio_display_rewrite/aegisub/src/main.cpp
- branches/audio_display_rewrite/aegisub/src/subs_edit_box.cpp
- …
Get rid of several no longer needed references to the audio display.
- 17:45 Changeset [4126] by
-
- branches/audio_display_rewrite/aegisub/src/audio_box.cpp
- branches/audio_display_rewrite/aegisub/src/audio_controller.h
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
- branches/audio_display_rewrite/aegisub/src/audio_display.h
- branches/audio_display_rewrite/aegisub/src/audio_timing_dialogue.cpp
Implement AudioDisplay::ScrollSampleRangeInView and getting the ideal visible range from a timing controller.
- 15:29 Ticket #1161 (Re-check the "word separators" list for spellchecker) created by
-
We have hyphen (U+002D) in the word separator characters list in utils.cpp but that one should actually affect spelling in many cases.
We should check if there's more bad characters like that in the list.
- 07:18 Developer/Refbuild created by
- Stub page, i'll fill it in tomorrow so I don't have to explain it multiple times. (including to myself!)
- 07:17 Developer edited by
- Add link to a new refbuild page. (diff)
- 05:21 Changeset [4125] by
-
- branches/audio_display_rewrite/aegisub/src/audio_controller.h
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
- branches/audio_display_rewrite/aegisub/src/audio_display.h
Prevent some more overdraw flicker by only redrawing the changed parts of the audio selection, when it changes.
- 04:00 Changeset [4124] by
-
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
- branches/audio_display_rewrite/aegisub/src/audio_timing_dialogue.cpp
Add marker drawing to the audio display.
- 02:57 Changeset [4123] by
-
- branches/audio_display_rewrite/aegisub/src/audio_controller.cpp
- branches/audio_display_rewrite/aegisub/src/audio_controller.h
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
- branches/audio_display_rewrite/aegisub/src/audio_display.h
- branches/audio_display_rewrite/aegisub/src/audio_timing.h
- branches/audio_display_rewrite/aegisub/src/audio_timing_dialogue.cpp
Implement a basic dialogue timing controller. Things are still purely visual, no support for actually grabbing times from dialogue or committing times to dialogue, and no interaction with time edit boxes either. Also missing is drawing of markers in the audio display.
The place the timing controllers should be constructed is also still an issue.
02/17/10:
- 20:07 Changeset [4122] by
-
- trunk/aegisub/src/frame_main_events.cpp
Just call Next/PrevFrame now that the audio playing behavior is implemented inside those methods.
- 20:04 Changeset [4121] by
-
- trunk/aegisub/src/video_context.cpp
- trunk/aegisub/src/video_context.h
- trunk/aegisub/src/video_slider.cpp
Move the logic to play the audio on stepping through video into video_context so that the VideoSlider's Next/PrevFrame can behave consistently regardless of where they're called from.
- 07:24 Changeset [4120] by
-
- trunk/aegisub/src/dialog_options.cpp
- trunk/aegisub/src/frame_main_events.cpp
- trunk/aegisub/src/options.cpp
Add an option to play audio when stepping through video, like some other video players do. Also, add .mov as a file format to load, as it is widely used on Mac and seems to work fine for me with ffmpeg.
- 03:45 Changeset [4119] by
-
- branches/audio_display_rewrite/aegisub/src/audio_controller.cpp
- branches/audio_display_rewrite/aegisub/src/audio_controller.h
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
- branches/audio_display_rewrite/aegisub/src/audio_display.h
- branches/audio_display_rewrite/aegisub/src/audio_karaoke.cpp
- branches/audio_display_rewrite/aegisub/src/audio_renderer.cpp
- branches/audio_display_rewrite/aegisub/src/audio_renderer.h
- branches/audio_display_rewrite/aegisub/src/audio_renderer_spectrum.cpp
Update a bunch of license headers for the new decade, and because I forgot to update them while otherwise working on the files.
- 03:42 Changeset [4118] by
-
- branches/audio_display_rewrite/aegisub/src/audio_timing.h
- branches/audio_display_rewrite/aegisub/src/audio_timing_dialogue.cpp
Forgot svn:keywords on new files... again.
- 03:34 Changeset [4117] by
-
- branches/audio_display_rewrite/aegisub/build/aegisub_vs2008/aegisub_vs2008.vcproj
- branches/audio_display_rewrite/aegisub/src/Makefile.am
- branches/audio_display_rewrite/aegisub/src/audio_timing.h
- branches/audio_display_rewrite/aegisub/src/audio_timing_dialogue.cpp
Add some skeleton code for the dialogue timing mode.
- 03:30 Changeset [4116] by
-
- branches/audio_display_rewrite/aegisub/build/aegisub_vs2008/aegisub_vs2008.vcproj
- branches/audio_display_rewrite/aegisub/src/setup.cpp
Minor build changes:
- Switch 64 bit debug build to regular program database, since the 64 bit compiler doesn't support Edit & Continue, and will constantly rebuild the entire program when that's enabled.
- Change some WXDEBUG for _DEBUG to support using wx trunk.
- 03:28 Changeset [4115] by
-
- branches/audio_display_rewrite/aegisub/src/audio_renderer.cpp
- branches/audio_display_rewrite/aegisub/src/audio_renderer.h
Hard-limit the audio bitmap caches at 16 MB each, hoping to prevent overrunning system bitmap resource limits.
- 00:49 Changeset [4114] by
-
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
- branches/audio_display_rewrite/aegisub/src/audio_renderer.cpp
Fix overdraw-induced flicker of audio display tracking cursor, and cursor-sticking-to-selection-ends visual glitch. It seems there was a kind of one-off error in AudioRenderer::Render().
02/16/10:
- 20:06 Changeset [4113] by
-
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
Stop timeline and scrollbar flicker in audio display when continually changing selection.
- 19:38 Changeset [4112] by
-
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
Refactor update region rendering of audio into a for loop, preparing for splitting the rendering of audio regions by the track cursor or markers.
- 19:16 Changeset [4111] by
-
- branches/audio_display_rewrite/aegisub/src/audio_controller.h
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
- branches/audio_display_rewrite/aegisub/src/audio_display.h
Switch playback cursor to be general purpose "track cursor", used to track playback when that's happening, and otherwise the mouse cursor and display time.
- 19:07 Changeset [4110] by
-
- branches/audio_display_rewrite/aegisub/src/audio_controller.cpp
Various minor fixes to audio controller implementation.
- 17:28 Changeset [4109] by
-
- branches/audio_display_rewrite/aegisub/src/audio_renderer_spectrum.cpp
Fix warning when size_t and and int are different sizes, such as on Win64.
- 17:27 Changeset [4108] by
-
- branches/audio_display_rewrite/aegisub/src/audio_controller.cpp
- branches/audio_display_rewrite/aegisub/src/audio_controller.h
- branches/audio_display_rewrite/aegisub/src/audio_display.cpp
- branches/audio_display_rewrite/aegisub/src/audio_display.h
- branches/audio_display_rewrite/aegisub/src/frame_main.cpp
- branches/audio_display_rewrite/aegisub/src/frame_main.h
- branches/audio_display_rewrite/aegisub/src/frame_main_events.cpp
Split AudioControllerEventListener into separate classes for audio and timing events.
- 05:38 Build/Windows edited by
- Note that the Win7 SDK seems to include the DirectSound headers and libraries (diff)
- 00:58 Build/Windows edited by
- Bring the page up to date about wxWidgets build and updated solution configuration (diff)
02/15/10:
- 20:56 Ticket #1160 (Problem whith zoom out a video) closed by
- duplicate: Duplicate of #1137.
- 20:49 Ticket #1160 (Problem whith zoom out a video) created by
-
When you want zoom out a video, the height is reduced but not the width.
Present on Windows XP pro and Seven.
- 04:06 Changeset [4107] by
-
- trunk/aegisub/src/utils.cpp
Add missing include.
02/14/10:
- 23:49 Ticket #1158 (Video provider issues) closed by
- fixed
- 23:46 Changeset [4106] by
-
- branches/aegisub_2.1.9/aegisub
- branches/aegisub_2.1.9/aegisub/src/dialog_style_manager.cpp
Merge r4105 from trunk.
- 23:44 Changeset [4105] by
-
- trunk/aegisub/src/dialog_style_manager.cpp
Fix debug assertion in style manager when "Copy" is clicked with zero styles selected.
- 23:30 Ticket #1060 (Styles manager not updating styles names in the lines properly) closed by
- fixed: (In [4104]) Merge r4103 from trunk. Closes #1060.
- 23:30 Changeset [4104] by
-
- branches/aegisub_2.1.9/aegisub/src/dialog_style_editor.cpp
- branches/aegisub_2.1.9/aegisub/src/dialog_style_editor.h
- branches/aegisub_2.1.9/aegisub/src/dialog_style_manager.cpp
- 23:26 Changeset [4103] by
-
- trunk/aegisub/src/dialog_style_editor.cpp
- trunk/aegisub/src/dialog_style_editor.h
- trunk/aegisub/src/dialog_style_manager.cpp
Change the logic for when the style editor asks the user if they wish to update existing lines when renaming a style to be based on whether it is a newly created style rather than whether the style's name starts with "Copy of". Updates #1060.
- 23:03 Ticket #1159 (Opening a video when a video is already open does not work correctly) closed by
- fixed: (In [4102]) Merge r4101 from trunk. Closes #1159.
- 23:03 Changeset [4102] by
-
- branches/aegisub_2.1.9/aegisub
- branches/aegisub_2.1.9/aegisub/src/video_context.cpp
- 23:02 Changeset [4101] by
-
- trunk/aegisub/src/video_context.cpp
Make VideoContext::SetVideo explicitly call VideoContext::UpdateDisplays rather than relying on the calling code restoring it to a consistent state. Updates #1159.
- 22:52 Ticket #1159 (Opening a video when a video is already open does not work correctly) created by
-
Opening a video without closing a currently open video fails to update some parts of the UI, such as the video slider. Hiding then showing the video fixes this, so there's probably just something not being refreshed which should be.
- 22:14 Developer/TracFeatures edited by
- Add note about merge ticket support. (diff)
- 19:09 Changeset [4100] by
-
- branches/aegisub_2.1.9/aegisub
- branches/aegisub_2.1.9/aegisub/src/video_out_gl.cpp
Merge r4099 from trunk.
- 19:08 Ticket #1153 (Video is blurry due to resizing even at 100% zoom) closed by
- fixed: (In [4098]) Merge r4037 and r4097 from trunk. Closes #1135.
- 19:07 Ticket #1135 (Honor docdir) reopened by
- Closed the wrong ticket.
- 19:06 Changeset [4099] by
-
- trunk/aegisub/src/video_out_gl.cpp
Fix compile error on non-windows caused by r4097.
- 18:52 Ticket #1135 (Honor docdir) closed by
- fixed: (In [4098]) Merge r4037 and r4097 from trunk. Closes #1135.
- 18:52 Changeset [4098] by
-
- branches/aegisub_2.1.9/aegisub
- branches/aegisub_2.1.9/aegisub/src/gl_text.cpp
- branches/aegisub_2.1.9/aegisub/src/video_display.cpp
- branches/aegisub_2.1.9/aegisub/src/video_display.h
- branches/aegisub_2.1.9/aegisub/src/video_out_gl.cpp
- branches/aegisub_2.1.9/aegisub/src/video_out_gl.h
- 18:41 Changeset [4097] by
-
- trunk/aegisub/src/video_out_gl.cpp
Rewrite the texture grid positioning code again, fixing several visual defects that showed up in OpenGL 1.1 mode. Updates #1153.
- 15:59 Changeset [4096] by
-
- branches/aegisub_2.1.9/aegisub/packages/win_installer/aegisub2-upgrade.iss
Change upgrade installer to check for 2.1.8 presence instead of 2.1.7 presence.
- 06:56 Ticket #1158 (Video provider issues) created by
-
The subs are 1 frame off when changing video provider from ffmpegsource to avisynth.
E.g -With ffms the last frame of a particular scene is 190, while with avisynth it is 189.
Another observation I made is that if I skim through the video by pressing the right directional key till I get to the 2 scenes after, then I go back to the first scene by pressing the left directional key, the subs end at the end of the scene change. (Video Provider: avisynth)
Also, switching the video provider while the video is loaded causes the subs to disappear from the video window.
When video window is attached, I cannot skim using the directional keys or by clicking on the progress bar. The indication arrow on the progress bar goes at the start, but video stays at the frame where I was when I switched the video provider. Same issue observed with video window detached.
Video is xvid in avi container with mp3 audio.
- 02:17 Changeset [4095] by
-
- branches/aegisub_2.1.9/aegisub/packages/win_installer/aegisub2-portable.iss
- branches/aegisub_2.1.9/aegisub/packages/win_installer/aegisub2-upgrade.iss
- branches/aegisub_2.1.9/aegisub/packages/win_installer/aegisub2.iss
- branches/aegisub_2.1.9/aegisub/packages/win_installer/fragment_setupbase.iss
Update version number in installer. (Upgrade installer notice about supported versions is not updated, neither are the tested file signatures.)
Switch Portable installer to use PrivilegesRequired=lowest feature added in Inno Setup 5.3.7, to avoid ever causing a UAC elevation prompt on Windows 6+.
02/13/10:
- 22:02 NewTicket edited by
- Since I added a plugin to restrict fields based on user permissions there's no need to mention what can and cannot be set. (diff)
- 19:39 Translations edited by
- Fix markup. (diff)
- 19:35 Translations edited by
- Add Polish mantainer. (diff)
- 19:33 Ticket #1157 (Add polish translation to windows.) created by
- 19:32 Ticket #1156 (Polish translation) closed by
- fixed: (In [4094]) Add Polish translation, thank you! closes #1156
- 19:32 Changeset [4094] by
-
- branches/aegisub_2.1.9/aegisub/po/LINGUAS
- branches/aegisub_2.1.9/aegisub/po/pl.po
- branches/aegisub_2.1.9/aegisub/po/wxstd-pl.mo
- branches/aegisub_2.1.9/aegisub/src/aegisublocale.cpp
Add Polish translation, thank you! closes #1156
- 10:35 Ticket #1156 (Polish translation) created by
-
Hello,
I make accessible the translation on the language Polish Aegisub in the version 2.1.8
All attentions regarding translations seen kindly and they will be helpful in the modernization of the language file.
02/12/10:
- 16:03 Changeset [4093] by
-
- branches/aegisub_2.1.9/aegisub/src/stdwx.h
Remove dependence on iconv header not used in 2.1.x.
- 16:00 Ticket #1146 (Regression in opening local help) closed by
- fixed: (In [4092]) Fix help file search logic. Closes #1146.
- 16:00 Changeset [4092] by
-
- branches/aegisub_2.1.9/aegisub/src/help_button.cpp
Fix help file search logic. Closes #1146.
- 15:05 Changeset [4091] by
-
- branches/aegisub_2.1.9/aegisub/build/aegisub_vs2008/aegisub_vs2008.vcproj
Change to 64 bit build, debug version is constantly rebuilt if it's attempted built with "Program database for edit & continue" instead of plain "Program database" for debug information.
02/11/10:
- 00:08 Ticket #1155 (Autosave not working 2.1.8) created by
-
Hello Aegisub team:
After saving and closing down aegisub to appy new windows updates to vista 64 ultimate, I found that .ass file no longer had any of the updates or retiming that I had done. The file had reverted to the original working copy. So, 3 days of timing this file will need to be redone. Autosave was enabled every 60 seconds. But, the .ass file in the autosave folder was not the most recent copy from yesterday, but the original file from last month.
I will not bother rebooting my computer until I fully complete timing this file.
Thank you for your useful software,
boinger
02/10/10:
- 23:23 Ticket #1154 (Skip CSRI helper library in linking to VSFilter) created by
-
There isn't really any reason to access VSFilter through the CSRI helper library as we do currently. The primary issue here is providing a solution for people who don't want to build VSFilter themselves, as it is a bit tricky.
The primary issue solved by doing this is ensuring that the correct version of VSFilter is always loaded and that it is always loaded.
- 00:48 Changeset [4090] by
-
- branches/aegisub_2.1.9/aegisub/src/video_display.cpp
- branches/aegisub_2.1.9/aegisub/src/video_out_gl.cpp
- branches/aegisub_2.1.9/aegisub/src/video_out_gl.h
Make VideoOutGL stop resizing the video frame for the sole purpose of working around problems resulting from resizing, resulting in blurry video at 100% zoom. Updates #1153.
02/09/10:
- 22:56 Ticket #1153 (Video is blurry due to resizing even at 100% zoom) created by
-
In 2.1.8, the video is never displayed with zero resizing, which significantly blurs the image. At 100% zoom, the video should not be resized at all.
- 05:31 Changeset [4089] by
-
- trunk/aegisub/src/agi_pre.h
- trunk/aegisub/src/dialog_fonts_collector.cpp
- trunk/aegisub/src/setup.cpp
- trunk/aegisub/src/subtitle_format.cpp
Change all incorrect uses of WXDEBUG to _DEBUG. WXDEBUG being defined does not necessarily mean that it is a debug build, and by default it is defined in release builds of wx as of 2.9.1.
02/08/10:
- 17:04 Ticket #1150 (Read metadatas to automatically resize anamorphic files (for example)) closed by
- invalid
- 16:54 Ticket #1151 (Adding DirectShow video provider) closed by
- wontfix: If you want one, write it yourself. We had one but it was removed because it didn't really work, nobody understood it and nobody wanted to maintain it.
- 04:38 Ticket #1152 (Make audio play without need to load it.) closed by
- wontfix: This will never happen, it was removed because it didn't work in most situations and we received a lot of bug reports. If you wish to review using audio please use an external player that focuses on A/V sync directly from files, this is the correct way to do it.
- 04:30 Ticket #1152 (Make audio play without need to load it.) created by
-
In the previous version was not necessary to load the audio so that it could be played.
This piss off who checks the karaoke FX and some typesettings as well as those who are just applying time shift in a film sub (think load 2 hours of audio in ram, its uses near 500mb ONLY for audio, PLUS the time for loading).
If possible would like an option that could choose whether the audio would be played the same in previous versions (2.1.7 or less) or as in the current (2.1.8).
- 01:51 Ticket #1151 (Adding DirectShow video provider) created by
-
I think it could be nice to add a DirectShow Video provider in order to allow the use of optimized decoders for video content like CoreAVC.
In 2.1.8 version, I see only FFMpegSource and Avisynth.
02/07/10:
- 17:48 Ticket #1150 (Read metadatas to automatically resize anamorphic files (for example)) created by
-
I get the feeling that avisynth is not very suited with Aegisub.
The only way I found for the moment is to use avs files to undo anamorphic processings (make 1440*1080 videos to 1920*1080).
But if aegisub reads metadatas like others players like Media Player Classic or others which say the real ratio of the video, the problem would be solved.
- 15:56 Ticket #1149 (Don't see plan's change in audio spectrum) created by
-
Since 2.1.8, I can't see anymore purple vertical lines when there are plan's change. So it's a lot more difficult to do time plans.
It worked with 2.1.7 release.
- 13:27 Build/Windows edited by
- Add note about instructions only being appropriate for 2.1.x branches (diff)
- 11:20 Ticket #1148 (Auto-commit isn't auto-commiting changes in karaoke mode) created by
-
I finally discovered why some of my ktimes were weird even if I was sure I did them corretly.
In karaoke mode, even with Auto-commit buttons pressed, when I change some syllabes (or even split), it doesn't change immediate. It's necessary to press F8/G in order to (manually) make the alterations.
Normals configurations. I recorded a video with the error being reproduced: http://www.kuriate.com.br/raijenki/aegisbug.avi
I want a minor patch >_>, downgrading to 2.1.7 will give more more bugs (could not lock buffer bug >_>).
Thanks.
- 10:59 Ticket #1147 (Multithreaded spectrum can cause race->crash with PCM audio provider) created by
-
The PCM WAV audio provider is not thread safe. It works most of the time, when it doesn't have to re-map the view of the file, but if two threads attempt to access parts of the audio that would lie in different parts of the file, a race condition can occur where one thread begins obtaining audio, reaches past the mapping check code and is ready/begins copying from the mapping. Simultaneously, another thread requests audio outside the current mapping, which causes the mapping code to tear down the current mapping and set up a new one. As a result, the copying in the first thread suddenly happens from an invalid memory location and the program crashes.
The only case where this can currently happen in Aegisub is the audio spectrum, since it is OpenMP multithreaded.
The proper solution is to allow the file mapping code to manage multiple mappings at a time and protect those mappings with multi-reader locks, possibly also adding some LRU logic to determine which mapping to tear down when the time comes.
This ties into #934, "Factor file mappings out of PCM reader".
