Crash when opening a hifi wav

[Zababa]

Aegisub 2.1.7 (built from SVN revision 3131) crashes on Windows XP SP3 when trying to open a 96 kHz, 32 bit (mono) PCM WAV. After I downsampled the wave to 44.1 kHz, 8 bit (mono) it opened allright.

[nielsm]

We don't handle any of the different kinds of sample depths above 16 bit.
One reason that we don't is that eg. 24 bit sample depth can mean at least four different things:

• Three bytes per sample, packed, big endian
• Three bytes per sample, packed, little endian
• Three bytes per sample, padded to four, padding at end, little endian
• Three bytes per sample, padded to four, padding at start, big endian

You can probably think of more different formats. We don't have the infrastructure to handle those different formats.

However I thought we handled it at least slightly gracefully, not crashing but just giving off an error.

[Zababa]

Handling it as an error message stating the limits of what WAV quality can be opened is fair enough.

[thefluff]

(In [3545]) Throw an error instead of crashing if user attempts to load audio with bitdepth >16bits/sample. Updates #996.