Ticket #929 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

"Split (by karaoke)" may make "Join (as karaoke)" create bogus k tags

Reported by: Kovensky Owned by: nielsm
Priority: normal Milestone: 2.1.8
Component: General Version: 2.1.7
Severity: major Keywords:
Cc: Platform: All
Sub Component: Subtitle - Editing

Description (last modified by verm) (diff)

Test line:

Dialogue: 0,0:00:49.34,0:00:55.81,Default,,0000,0000,0000,,{k31}hi{k29}me

Normal behavior:

  • Select Test line, right click, choose "Split (by karaoke)": 
    Dialogue: 0,0:00:49.34,0:00:49.65,Default,,0000,0000,0000,,hi
Dialogue: 0,0:00:49.65,0:00:49.94,Default,,0000,0000,0000,,me
  • Select both resulting lines, right click, choose "Join (as karaoke)": 
    Dialogue:0,0:00:49.34,0:00:49.94,Default,,0000,0000,0000,,{k31}hi{k29}me

To reproduce the bug:

  • Select test line, right click, select "Split (by karaoke)": 
    Dialogue: 0,0:00:49.34,0:00:49.65,Default,,0000,0000,0000,,hi
Dialogue: 0,0:00:49.65,0:00:49.94,Default,,0000,0000,0000,,me
  • Select both resulting lines, right click, select "Split (by karaoke)": 
    Dialogue: 0,0:00:49.34,0:00:49.65,Default,,0000,0000,0000,,hi
Dialogue: 0,0:00:49.65,0:00:49.94,Default,,0000,0000,0000,,me
  • Select both lines again, right click, select "Join (by karaoke)": 
    Dialogue:0,0:00:49.34,0:00:49.65,Default,,0000,0000,0000,,{k0}hi{k31}{k0}me

Change History

comment:1 Changed 3 years ago by Kovensky

Also related is #928, since fixing it would prevent the second "Split (by karaoke)" from being executed at all.

comment:2 Changed 3 years ago by verm

  • Description modified (diff)

Reformat description.

comment:3 Changed 3 years ago by nielsm

  • Owner set to nielsm
  • Status changed from new to accepted
  • Sub Component set to Subtitle - Editing

What? This makes no sense.

comment:4 Changed 3 years ago by nielsm

Oh I see what's happening... when there's no karaoke on a line, the line duration is changed to 0, ie. end time changed to start time. Should be fixable.

comment:5 Changed 3 years ago by nielsm

  • Status changed from accepted to closed
  • Resolution set to fixed

(In [3192]) Re-do "split by karaoke" code using the common ass_karaoke code and adding a little more sanity checking, fixes #929.

comment:6 Changed 3 years ago by nielsm

(In [3193]) Merge trunk r3192 into 2.1.8. It builds so it must be good. Updates #929.

comment:7 Changed 3 years ago by nielsm

  • Milestone set to 2.1.8

Right, forgot to set milestone...

Note: See TracTickets for help on using tickets.