Opened 4 years ago

Closed 4 years ago

#910 closed defect (fixed)

Regression in VideoContext.

Reported by: verm Owned by: nielsm
Priority: normal Milestone: 2.1.7
Component: General Version: devel
Severity: crash Keywords:
Cc: Platform: All
Sub Component:

Description (last modified by verm)

r3014 crashes on 10.4.11/PPC when exiting:

#0  0x0021f420 in VideoContext::~VideoContext ()
#1  0x0021c4e8 in VideoContext::Clear ()
#2  0x001ac9f4 in AegisubApp::OnExit ()
#3  0x023f5644 in wxEntry(int&, wchar_t**)::CallOnExit::~CallOnExit () at init.cpp:454
#4  0x023f5774 in wxEntry (argc=@0x255ca68, argv=0x5124020) at init.cpp:460
#5  0x023f587c in wxEntry (argc=@0xbffffa78, argv=0xbffffb2c) at init.cpp:472
#6  0x001ac9b8 in main ()

Attachments (1)

bug-910-fix1.patch​ (1.3 KB) - added by nielsm 4 years ago.
Blind fix of bug

Download all attachments as: .zip

Change History (6)

comment:1 Changed 4 years ago by verm

  • Description modified (diff)

Whoops, fix markup.

comment:2 Changed 4 years ago by verm

I should have noted this the first time, I checked r3013, which doesn't have this problem.

Changed 4 years ago by nielsm

Blind fix of bug

comment:3 Changed 4 years ago by nielsm

I attached a patch that should fix the problem.
The problem is that Aegisub doesn't keep track of whether it or wx owns the GL context. In the case of wxMac, wx will be the owning part, but we delete it regardless, causing problems (double free).

comment:4 Changed 4 years ago by verm

This patch fixes r3127 on PPC.

comment:5 Changed 4 years ago by nielsm

  • Resolution set to fixed
  • Status changed from new to closed

(In [6848121]) Apply patch to fix #910.

Note: See TracTickets for help on using tickets.