Opened 5 years ago

Closed 4 years ago

#775 closed defect (fixed)

Auto4 configuration dialog: floatedit does not display default value

Reported by: ai-chan Owned by: nielsm
Priority: normal Milestone: 2.1.7
Component: Scripting Version: 2.1.2
Severity: minor Keywords: auto3 lua
Cc: Platform: All
Sub Component:

Description

Floatedit control in auto4 script's configuration dialog does not display default value set in the dialog control table.

Possible fix:
in ​http://svn.aegisub.net/trunk/aegisub/auto4_lua_dialog.cpp, Automation4::FloatEdit::Create(wxWindow *parent)

line:
cw = new wxTextCtrl(parent, -1, text, wxDefaultPosition, wxDefaultSize, 0);

should be:
cw = new wxTextCtrl(parent, -1, value, wxDefaultPosition, wxDefaultSize, 0);

Change History (6)

comment:1 Changed 5 years ago by ai-chan

You might have to use wxString::Format() on the "value" variable ...

comment:2 Changed 5 years ago by nielsm

  • Owner set to nielsm
  • Status changed from new to assigned

comment:3 Changed 5 years ago by nielsm

Should be fixed in SVN r2335, but don't have a test case so I can close the bug.

comment:4 Changed 4 years ago by nielsm

  • Milestone changed from 2.1.2 to 2.2.0
  • Platform set to All

comment:5 Changed 4 years ago by nielsm

(In [28d4ed7]) Extend Auto 4 Lua config dialogues test case to cover most interesting cases of controls.
Updates #775 and #776 since they need those cases.

comment:6 Changed 4 years ago by nielsm

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [277adad]) Fix a bunch of bugs with config dialogues in Auto 4 Lua:

  • When default buttons were present, pushing OK caused no button code to be returned at all.
  • A load of controls not handling default/initial values properly, closes #775 and #776
Note: See TracTickets for help on using tickets.