Ticket #748 (closed defect: fixed)

Opened 4 years ago

Last modified 2 years ago

Screen colour dropper is broken on non-Windows

Reported by: nielsm Owned by: nielsm
Priority: normal Milestone: 2.1.8
Component: General Version:
Severity: major Keywords:
Cc: Platform: Unix
Sub Component:

Description (last modified by verm) (diff)

The colour dropper tool in the colour dialogue is broken on all non-Windows versions.
It is confirmed broken on GTK and Mac builds.

It'll probably need platform-specific implementations.

ADDITIONAL INFORMATION:
This sample is probably useful for a Mac implementation:
 http://developer.apple.com/samplecode/OpenGLScreenSnapshot/index.html

Change History

comment:1 Changed 4 years ago by nielsm

  • Keywords confirmed added

comment:2 Changed 3 years ago by nielsm

  • Keywords confirmed removed
  • Platform set to All
  • Milestone set to 2.3.0

Hopefully we can get this fixed soon.
Making this the general issue about making working droppers for the various platforms, #861 can be about removing the dropper from non-Windows builds.

comment:3 Changed 2 years ago by verm

  • Platform changed from All to Unix
  • Description modified (diff)
  • Milestone changed from 2.3.0 to 2.1.8

Set to milestone:2.1.8 as we have a fix for this that works on GTK. Hopefully OS X can be fixed as well.

comment:4 Changed 2 years ago by greg

(In [3976]) Backport color dropper fixes (r3975). Addresses #748.

comment:5 Changed 2 years ago by nielsm

(In [3996]) Further on the way to making the colour dropper work on OS X. Now the screen bitmap is captured correctly, but still not drawn correctly.
Updates #748.

comment:6 Changed 2 years ago by verm

(In [3997]) Fix Recent box in colour dialogue on OS X, the drawing failure was due to alpha reversal.
Fix Dropper functionality in colour dialogue on OS X, work around wxMemoryDC::GetPixel() not being implemented.
Updates #748. Close when merged to trunk.

comment:7 Changed 2 years ago by verm

  • Owner set to nielsm
  • Status changed from new to assigned

Closing as fixed, see #1114 for the merge ticket.

comment:8 Changed 2 years ago by verm

  • Status changed from assigned to closed
  • Resolution set to fixed

Whoops, the last operation assigned it, really close it this time.

Note: See TracTickets for help on using tickets.