Ticket #717 (closed defect: fixed)

Opened 4 years ago

Last modified 18 months ago

Removed files stay in MRU lists even after failed opening them

Reported by: nielsm Owned by: Plorkyeran
Priority: normal Milestone: 3.0.0
Component: General Version: devel
Severity: minor Keywords: confirmed
Cc: Platform: All
Sub Component:

Description (last modified by verm) (diff)

If you move/delete a file that's in one of the Recent lists and then try opening it from the Recent list, opening obviously fails. But the file stays on the Recent list even though it's no longer valid.

ADDITIONAL INFORMATION:
Most other applications remove dead files from MRU lists either when the list is about to be displayed, or when attempting to open it.
I would recommend the latter, because if any of the files in MRU are on removeable media (diskette, CD, network) stat()ing all of them might produce unreasonable delays.

Change History

comment:1 Changed 4 years ago by nielsm

  • Keywords confirmed added

comment:2 Changed 4 years ago by nielsm

Some investigation and testing a (failed) fix shows that the MRU handling code is buried deep all over the place.
It might take some semi-serious reworking of the internal error/exception handling, to make it more structured, have less pure strings/chararrays and more typed exceptions. Only that way can really make it easy to catch file-unopenable errors etc and tell them apart from "user clicked cancel" etc.

comment:3 Changed 21 months ago by verm

  • Platform set to All
  • Description modified (diff)
  • Milestone set to 2.2.0

Again, very easily supported with the new MRU system, however I won't be making this change myself.

comment:4 Changed 19 months ago by Plorkyeran

  • Owner set to Plorkyeran
  • Status changed from new to accepted

comment:5 Changed 18 months ago by plorkyeran

  • Status changed from accepted to closed
  • Version set to devel
  • Resolution set to fixed

(In [4717]) Make video and audio providers throw typed exceptions.

Don't display error messages and try other providers when the user
cancels loading a file.

Remove files from the MRU lists if they can't be found.

Closes #717.

comment:6 Changed 18 months ago by plorkyeran

(In [4721]) Also remove timecodes and keyframes from the MRU lists when they cannot be found. Updates #717.

comment:7 Changed 18 months ago by verm

  • Milestone changed from 2.2.0 to 3.0.0

Bump 2.2.0 tickets to milestone:3.0.0 (2.2.0 is becoming 3.0.0)

Note: See TracTickets for help on using tickets.