Ticket #548 (closed defect: fixed)

Opened 4 years ago

Last modified 2 days ago

Timing Postproc keyframe snapping should use ms instead of frames

Reported by: nielsm Owned by:
Priority: normal Milestone: 3.0.0
Component: General Version:
Severity: minor Keywords: acknowledged
Cc: Platform: All
Sub Component:

Description (last modified by Plorkyeran) (diff)

Specifying the snap distances for keyframe snapping in the Timing Postprocessor in frames rather than milliseconds might not be a good idea, especially if considering the case of VFR.
The need for keyframe snapping is to minimise the visual problem of subs blinking on/off close to a scene change, but "close" should be defined in playback time, which can vary a lot depending on the frame rate of the video. With VFR video the frames around different scene changes can have varying lengths, meaning the snapping will be visually uneven.

Change History

comment:1 Changed 4 years ago by nielsm

  • Keywords acknowledged added

comment:2 Changed 3 years ago by TheFluff

I will take a look at doing this, but it'll have to wait until after the strings thaw/feature thaw.

comment:3 Changed 6 months ago by FichteFoll

What about using both, frames and time, to specify the snapping range? I can imagine cases when just resnapping to keyframes that are 1 or max 2 frames async would be useful. Furthermore, this does not involve new code since snapping to frames is already possible.

comment:4 Changed 3 months ago by tophf

It would be a indeed an extremely useful feature!
Time-Shift has this capability like forever.

comment:5 Changed 2 days ago by Plorkyeran

  • Status changed from new to closed
  • Platform set to All
  • Resolution set to fixed
  • Description modified (diff)
  • Milestone set to 3.0.0

Done in r6311.

Note: See TracTickets for help on using tickets.