Opened 6 years ago
Closed 8 months ago
#508 closed defect (fixed)
The Numpad Enter key in 2.00 build 1458
| Reported by: | Yakhobian | Owned by: | nielsm |
|---|---|---|---|
| Priority: | low | Milestone: | 3.0.0 |
| Component: | General | Version: | 1.10 |
| Severity: | minor | Keywords: | problemwithwx |
| Cc: | Platform: | Windows | |
| Sub Component: |
Description (last modified by Plorkyeran)
The numpad enter key doesn't commit changes when you just click a line from the subtitle list and perform some alteration with a keyboard shortcut. Only the main enter key works in this case.
It does work, however, when you click on the text field for the selected line.
Change History (12)
comment:1 Changed 6 years ago by ArchMageZeratuL
- Keywords confirmed added
comment:2 Changed 6 years ago by ArchMageZeratuL
- Keywords resolved added; confirmed removed
- Owner set to ArchMageZeratuL
- Resolution set to fixed
- Status changed from new to closed
comment:3 Changed 6 years ago by ArchMageZeratuL
- Keywords confirmed added; resolved removed
- Status changed from closed to new
comment:4 Changed 5 years ago by ArchMageZeratuL
- Owner ArchMageZeratuL deleted
comment:5 Changed 4 years ago by nielsm
- Milestone changed from 1.1.0 to 2.2.0
- Platform set to All
comment:6 Changed 4 years ago by nielsm
- Owner set to nielsm
- Status changed from new to accepted
comment:7 Changed 4 years ago by nielsm
- Keywords problemwithwx added; confirmed removed
- Platform changed from All to Windows
comment:8 Changed 4 years ago by nielsm
- Priority changed from normal to low
Putting this to low priority, as this only affects users of Medusa timing mode, which I believe to be a very small minority.
I'll investigate the deeper problem if I get time, but I somewhat expect this to be pushed to the next release.
comment:9 Changed 4 years ago by verm
- Milestone changed from 2.1.7 to 2.2.0
Move ticket to milestone:2.2.0 as milestone:2.1.7 became a windows-only maintenance release.
comment:10 Changed 4 years ago by nielsm
Tested with new wx 2.9 builds, seems to still be a problem.
The numpad enter is processed as a regular return key in the edit box, and not at all for any setting of Medusa-mode when the audio display has focus.
comment:11 Changed 3 years ago by verm
- Milestone changed from 2.2.0 to 3.0.0
Bump 2.2.0 tickets to milestone:3.0.0 (2.2.0 is becoming 3.0.0)
comment:12 Changed 8 months ago by Plorkyeran
- Description modified (diff)
- Milestone changed from 3.0.2 to 3.0.0
- Status changed from accepted to closed
Can't reproduce with 3.0.0. I suspect the change to processing hotkeys in a charhook rather than via accelerators was responsible for fixing this.
It seems this might be a problem with the wxMSW handling of accelerators. Even though the numpad enter key is registered in the accelerator table, no WM_COMMAND message is ever produced from Windows when you push it. However, if Medusa-mode is disabled and the accelerator is then not registered, I get WM_KEYDOWN messages for pushing numpad enter.
wx bug 10023