Colour picker always shows up maximized

[cantabile]

"Maximized" : true

This ended up in my config (dunno how, or when). Ever since then, the colour picker has always showed up maximized. In my (arguably crazy) window manager, this non-resizeable dialog is shown at the same size whether it's maximized or not, but when it's maximized, I can't move it. The result: the colour picker is stuck in the top left corner, covering most of the video.

The problem appears to be in persist_location.cpp, where the dialog's maximized state is saved only when the dialog is (un)minimized. Its maximized state is also set based on its minimized state, which doesn't look right at all.

I think it's reasonable to record the dialog's maximized state when closing it. Unfortunately, wxCloseEvent is not fired when pressing esc or clicking the "close" button. wxShowEvent is fired when pressing esc, clicking the X button and clicking the "close" button, but, if the wx documentation is to be trusted, wxShowEvent is not available in osx...

[cantabile]

Uhh, yeah.

aegisub r6442 (trunk), wxgtk 2.9.3, arch linux (64 bit).

[plorkyeran]

(In [6445]) Check whether the dialog is maximized rather than whether it's not iconized in PersistLocation. Updates #1451.

[plorkyeran]

(In [6446]) Ignore the Maximize option for dialogs which aren't supposed to be maximizable. Closes #1451.