Ticket #1164 (closed defect: fixed)

Opened 2 years ago

Last modified 20 months ago

Potential crash in update checker

Reported by: nielsm Owned by: nielsm
Priority: high Milestone: 2.1.9
Component: Interface Version: 2.1.8
Severity: crash Keywords:
Cc: Platform: All
Sub Component:

Description

Missing error checking in the update checker can cause crashes.

In dialog_version_check.cpp, AegisubVersionCheckerThread::DoCheck(), the following line:

std::auto_ptr<wxInputStream> stream(http.GetInputStream(path));

No check is made whether http.GetInputStream() returns 0, which might cause crashes later.

Attachments

crashlog.txt Download (3.5 KB) - added by nielsm 2 years ago.
Crash log pointing to the problem

Change History

Changed 2 years ago by nielsm

Crash log pointing to the problem

comment:1 Changed 20 months ago by nielsm

(In [4383]) Add a null-pointer check to update checker. Updates #1164.

comment:2 Changed 20 months ago by nielsm

  • Status changed from new to closed
  • Resolution set to fixed

(In [4384]) Merge r4383, closes #1164.

Note: See TracTickets for help on using tickets.