Ticket #1135 (closed enhancement: fixed)

Opened 2 years ago

Last modified 20 months ago

Honor docdir

Reported by: RedDwarf69 Owned by: verm
Priority: normal Milestone: 2.1.9
Component: General Version: 2.1.8
Severity: minor Keywords:
Cc: Platform: All
Sub Component:

Description

Autotools provide a docdir variable. A ./configure --help shows it, but then isn't honored.

Attachments

aegisub-2.1.8-docdir.patch Download (448 bytes) - added by RedDwarf69 2 years ago.
Patch

Change History

Changed 2 years ago by RedDwarf69

Patch

comment:1 Changed 2 years ago by verm

  • Status changed from new to infoneeded_new
  • Milestone set to 2.1.9

I'm not sure this is the right fix, what are you trying to do? It's supposed to install as ${dir}/aegisub/<version> eg. ${dir}/aegisub/2.1/ Are you wanting to change ${dir} or the entire path so it's installed in docdir dropping the path info?

This requires source changes as well since the paths are assumed in the source to be $prefix/share/doc/aegisub/<version>. We don't use this for docs but we use it for data, if this is to be fixed datadir needs to be changed as well.

comment:2 Changed 2 years ago by RedDwarf69

Frankly, I just attached it without looking too much into it. I had the patch since a long time ago and just saw it now when packaging 2.1.8.

It's just that in openSUSE docs are in /usr/share/doc/packages/<package> and docdir was ignored.

comment:3 Changed 2 years ago by verm

  • Status changed from infoneeded_new to new

Fair enough, I'll figure out a proper fix to honor these in milestone:2.1.9 thanks for the report!

comment:4 Changed 2 years ago by verm

  • Owner set to verm
  • Status changed from new to assigned

comment:5 Changed 2 years ago by plorkyeran

  • Status changed from assigned to closed
  • Resolution set to fixed

(In [4098]) Merge r4037 and r4097 from trunk. Closes #1135.

comment:6 Changed 2 years ago by Plorkyeran

  • Status changed from closed to reopened
  • Resolution fixed deleted

Closed the wrong ticket.

comment:7 Changed 20 months ago by verm

(In [4506]) Change the names of the aegisub doc and data dirs to AGI_* variables to follow previous conventions. updates #1135

comment:8 Changed 20 months ago by verm

  • Status changed from reopened to closed
  • Resolution set to fixed

(In [4570]) Add patch to honor docdir, I decided to just commit this as-is since 2.1.x is going to be EOLd after 2.1.10, thanks for the submission! closes #1135.

Note: See TracTickets for help on using tickets.