Ticket #1117 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Toolbar flickers when changing line

Reported by: nielsm Owned by: nielsm
Priority: low Milestone: 2.1.8
Component: Interface Version: devel
Severity: minor Keywords:
Cc: Platform: Windows
Sub Component:

Description

Really minor and not very important thing, when you change the active line by clicking in the subtitle grid, the main toolbar flickers.
There has to be a way to avoid that.

Change History

comment:1 Changed 2 years ago by gpower2

@frame_main.cpp in line 652 there is toolbar->Realize();

It is inside the function void FrameMain::UpdateToolbar()

According to wxWiki, Realize() should be called after the adding of controls in the toolbar. Since the controls are already there when updating, perhaps this causes the flikering thing.
Perhaps removing it completely or replacing by a series of Refresh commands like

toolbar->FindById(Menu_Video_JumpTo)->Refresh(false); (false in order NOT to erase the background)

could do the trick.

Unfortunately I can't currently compile and test the fix myself, I hope I was of help...

comment:2 Changed 2 years ago by nielsm

  • Owner set to nielsm
  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from 2.1.9 to 2.1.8

(In [4009]) Fix #1117, only call toolbar->Realize() if changes to button states were actually made.

Note: See TracTickets for help on using tickets.