Ticket #1007 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Insorrect work with time and fs+ tag using "transform framerate" function

Reported by: B.F. Owned by: Plorkyeran
Priority: high Milestone: 2.1.8
Component: General Version: 2.1.7
Severity: minor Keywords:
Cc: Platform: All
Sub Component:

Description (last modified by Plorkyeran) (diff)

If I export subtitles using "transform framerate" function, Aegisub remove "+" from "fs+"

before:
0,0:22:22.64,0:22:22.93,EdSong30000,0000,0000{move(343,11,332,17,0,288) (0,288,fs+21c&He98c543c0)}Spi

after:
0,0:22:42.42,0:22:42.71,EdSong30000,0000,0000{move(343,11,332,17,0,292) (0,292,fs21c&He98c543c0)}Spi

also if it "transforme framerate" in karaoke like this
Dialogue: 0,0:22:33.27,0:22:37.18,EdSong30000,0000,0000{ (0,1,alpha&HFF)}Spi{

(540,540,alpha&HFF)}der

it can replace " (0,1" with " (0,0" and broke the animation
Dialogue: 0,0:22:22.64,0:22:26.42,EdSong30000,0000,0000{ (0,0,alpha&HFF)}Spi{

(493,493,alpha&HFF)}der

Change History

comment:1 Changed 2 years ago by plorkyeran

(In [3838]) Add \fs+ and \fs- to the ASS parser so they aren't killed by transforms. Updates #1007.

comment:2 Changed 2 years ago by plorkyeran

(In [3839]) Prevent times from rounding to the magic zero in the framerate transform. Updates #1007.

comment:3 Changed 2 years ago by plorkyeran

  • Status changed from new to closed
  • Resolution set to fixed

(In [3840]) Merge framerate transform fixes in r3838-r3839 from trunk. Closes #1007.

comment:4 Changed 2 years ago by Plorkyeran

  • Description modified (diff)
  • Milestone set to 2.1.8

comment:5 Changed 2 years ago by verm

  • Owner set to Plorkyeran

comment:6 Changed 2 years ago by B.F.

Check fixes on r3974 beta.
"Transform framerate" filter now work without problems.
Thanks.

P.S.
Beta is still crash sometimes, but I hope final version will be stable.

comment:7 Changed 2 years ago by verm

  • Priority changed from normal to high
  • Status changed from closed to reopened
  • Resolution fixed deleted

Can we double check this to make sure it's really fixed?

comment:8 Changed 2 years ago by B.F.

It fixed.
Re-check on the 2 different scripts, and found no problem in r3974.
Both broke if i export them in the 2.1.7.

comment:9 Changed 2 years ago by verm

  • Status changed from reopened to closed
  • Resolution set to fixed

doh, I took the 'still crash sometimes' as related to this bug, but it was meant to be 'in general'. Closing as fixed.

Note: See TracTickets for help on using tickets.